Enhanced pokeball-management for sniping #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment the bot stops sniping if you fall below the MinPokeballsToSnipe value. For example with MinPokeballsToSnipe = 100 he will stop sniping if you fall to 99 Pokeballs. I don't think that was intended. With the fix he will snipe until he has MinPokeballsWhileSnipe pokeballs left and only start sniping if he has at least MinPokeballsToSnipe.
… into FIX-PokeballManagmentForSniping No Conflicts
schnapster
pushed a commit
to schnapster/NecroBot
that referenced
this pull request
Dec 8, 2016
…lManagmentForSniping Enhanced pokeball-management for sniping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces "Fixed MinPokeballsToSnipe".
At the moment the bot stops sniping if he falls below the MinPokeballsToSnipe value. For example with "MinPokeballsToSnipe" = 100 he will stop sniping if he has 99 pokeballs left.
I don't think that was intended. With the fix he will snipe until he has MinPokeballsWhileSnipe pokeballs left and only start sniping if he has at least MinPokeballsToSnipe pokeballs.