Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request for refactoring of the logging messages #1731

Merged
merged 10 commits into from
Aug 1, 2016
Merged

Conversation

igeligel
Copy link
Contributor

@igeligel igeligel commented Aug 1, 2016

What i have done:

  • Created Model for logging strings which can be initialized by a static method
  • In the method use null propagation together with ternary operator to set the default string or the translated string
  • Changed access modifiers of the constructor of the logger to internal
  • Fixed indentation of xml documentation comments and normal comments to fit official guidelines
  • Added new line at end of the file
  • Update Access Modifiers of the Console Event listener and change the parameter names there

Fix indentation of xml documentation
Edit the access modifiers of the methods to more strict structure
add model for logging strings
Extending the model and fix the typo in transferred
Instantiate the logging model with setting the session and use the Model
for the logging part
edit access modifiers to internal for Listen(...) and make the handlers
private
@DorianLoeben
Copy link
Contributor

Great job. Did anything in the output change or just in the usage/internals?

Edit naming of event parameters
@igeligel
Copy link
Contributor Author

igeligel commented Aug 1, 2016

There were no changes. I made a picture of the current console output.

Output strings were not changed but i was close to fix a typo for the transferred string but i do not know any guideline on those strings (like max length).

Transferred =
                session?.Translation.GetTranslation(
                    TranslationString.LogEntryTransfered) ?? "TRANSFERED";

Should be written with two r's i believe. If it is allowed ill change it too.

@NecronomiconCoding NecronomiconCoding merged commit 3d9d3bb into NecronomiconCoding:master Aug 1, 2016
schnapster pushed a commit to schnapster/NecroBot that referenced this pull request Dec 8, 2016
Pull request for refactoring of the logging messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants