Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multiple usability improvements #2728

Merged
merged 10 commits into from
Aug 6, 2016
Merged

Added multiple usability improvements #2728

merged 10 commits into from
Aug 6, 2016

Conversation

Andrerm124
Copy link
Contributor

@Andrerm124 Andrerm124 commented Aug 5, 2016

Resubmitted #2711 with fresh clone

CHANGELOG:

  • Added a new method to pull the system translation when new configs are created. It will then ask the user if they would like to enter a new language code (And then build the config)
  • Now asks the user if they would like to download/install a new update (When there is one) and will display any new options added in the version.
  • Implemented functions to allow for the translation of pokemon moves
  • If the user is updating the bot and new options are added, ask the user if they would like to open the config file to view the new additions.
  • Added a low level killswitch to disable the bot and print a notification for the reason. This is only for situations whereby the bot may be broken. This was made extremely quickly and I believe there should be better implementation of this idea

This commit has been tested by only two users, one on an english system, another on a french system. Multiple logical processes were tested however there may still be issues to be found

Credits to @Oolaruu for the ideas

@Andrerm124 Andrerm124 changed the title Resubmitted #2711 with fresh clone Added multiple usability improvements Aug 5, 2016
This killswitch is simply to stop the bot when any major issues occur.

This may help users in the future understand when a fatal issue of the
bot has occurred. For example, if this system was implemented when
Unknown6 was pushed, we could have killed the bot and given a reason
# Conflicts:
#	KillSwitch.txt
@BornSupercharged
Copy link
Contributor

This branch has conflicts that must be resolved

@BornSupercharged
Copy link
Contributor

Also, you will have to change Program.cs from:
private static string strKillSwitchUri =
"https://raw.githubusercontent.com/Andrerm124/NecroBot/master/KillSwitch.txt";

To:
private static string strKillSwitchUri =
"https://raw.githubusercontent.com/NECROBOTIO/NecroBot/master/KillSwitch.txt";

@Oolaruu
Copy link
Contributor

Oolaruu commented Aug 6, 2016

What about all the translation files I have submitted ?
Need to revert it ?

@Andrerm124
Copy link
Contributor Author

No it'll be fine. I uploaded the French translation forgetting that you'd already done it. I'll fix this up when I get home

@BornSupercharged BornSupercharged merged commit 1caf990 into NecronomiconCoding:master Aug 6, 2016
@Oolaruu
Copy link
Contributor

Oolaruu commented Aug 7, 2016

About the french language, still need few more hours, i'll update it myself.

schnapster pushed a commit to schnapster/NecroBot that referenced this pull request Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants