Improved handling for some edge cases with the maximum radius feature

[Daylend]

A few users were confused when the program would endlessly list their highest Pokemon. This should hopefully fix that.

[c-zar]

Still keeps listing it. :(

[Daylend]

@qaqsd123 Does it at least give a warning saying there are no PokeStops nearby? Because it should.

[c-zar]

Didn't get that far

On Sun, Jul 24, 2016, 3:02 AM Daylend notifications@github.com wrote:

@qaqsd123 https://github.com/qaqsd123 Does it at least give a warning
saying there are no PokeStops nearby?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#364 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATQZftgvFWgO7n-IG40C34lF1CdaXcgTks5qYw4cgaJpZM4JThGS
.

[Daylend]

Coords.ini is used to store the last location the bot was at. If limiting the distance was based on Coords.ini, it wouldn't be limiting the distance at all. It would only be able to travel to PokeStops x meters away from its current position, which is NOT what was intended. If you use the first coords found in Coords.ini, you would slowly drift away from your original position as the bot is reset, eventually having to put new coordinates in to keep the bot in the same place.

This PR prevents edge cases where you somehow get away from the predefined boundaries. This usually happens when a user forgets to clear their Coords.ini file before moving to a new start location as set in UserSettings.settings.

The point is to allow the user to save their position regardless of where they roam and continue where they left off, but keep them within a predefined area that doesn't change.

Edit: This was a reply to a now deleted comment.

[cvax]

You are right. How about renaming Coords.ini to LastCoords.ini then to avoid confusion?

[Daylend]

Sure. Someone just needs to put up a PR. Feel free to if you'd like.

[cvax]

Also, if we are already going to walk back to the start, shouldn't we be spinning PokeStops along the way instead of just catching Pokemon? Could be a real long walk if someone was jumping across the country and didn't change both coords.

[Daylend]

Someone shouldn't be using this to walk across the country. This is for the cases where the bot is a minimal distance away from the radius. Otherwise they should see the message generated and restart the bot with the proper coordinates.

[ThomasSRL]

Dont worry @Daylend , it seems perfect as is! Hope it gets accepted!