Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature to reset coords based on distance and time last run #452

Merged
merged 9 commits into from
Jul 24, 2016

Conversation

CTDragon
Copy link

Added feature to reset coords based on distance and time last run

Also fixed bug with log causing crash in master branch

@CTDragon
Copy link
Author

Merged with latest master and reviewed Logger merge

@NecronomiconCoding
Copy link
Owner

conflicts :)

# Conflicts:
#	PokemonGo.RocketAPI/Client.cs
#	PokemonGo.RocketAPI/Logger.cs

Resolved merge using kdiff3
@CTDragon
Copy link
Author

Resolved again

@NecronomiconCoding
Copy link
Owner

So what exactly has been added?

@CTDragon
Copy link
Author

When the program is first run, if the user could have traveled realistically back to the default location from the last known location, it deletes the coords.ini file so the logic will start from the default location.

@CTDragon
Copy link
Author

The code essentially looks and says if (distanceBetweenDefaultAndLastKnownLocation/timeCoordsLastUpdated) < 80kmph), start at the default location, otherwise continue from last known location and continue as normal.

@CTDragon
Copy link
Author

I have tested it with the latest merges and it works

@CTDragon
Copy link
Author

The point is, I (and someone who submitted an issue) like to start from the default location because there are several stops right there. If I haven't run it in a while, I want to start from that default point where there are several stops, not somewhere else.

@CTDragon
Copy link
Author

CTDragon commented Jul 24, 2016

image

I do want it to venture out from there though and not set too small of a max travel distance because all that area has is pidgey and ratatta. lol.

@bjornegrim
Copy link
Contributor

seems like a great feature to me

@NecronomiconCoding NecronomiconCoding merged commit 493798e into NecronomiconCoding:master Jul 24, 2016
@OverlordQ
Copy link
Contributor

OverlordQ commented Jul 24, 2016

This is the stupidest 'realistic' idea ever. Nothing says "not-realistic' than always starting at the exact same spot every time.

If this is kept, it definately needs to be a user config with defaulting to off.

@CTDragon
Copy link
Author

It's not a realistic feature, it's a start over without deleting the coords file feature...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants