Fixed a logic error in GetDuplicatePokemonToTransfer & reduced size of GetXpDiff #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f GetXpDiff With KeepPokemonsThatCanEvolve=true it previously also kept all pokemons that couldn't evolve. Added KeepPokemonsThatCanEvolve to Settings
| continue; | ||
| var amountToSkip = _client.Settings.KeepMinDuplicatePokemon; | ||
|
|
||
| if (settings.CandyToEvolve > 0 && familyCandy.Candy / settings.CandyToEvolve > amountToSkip) |
There was a problem hiding this comment.
extract familyCandy.Candy / settings.CandyToEvolve out as you use it twice.
There was a problem hiding this comment.
sry i thought i'd rather save a line..
| if (settings.CandyToEvolve == 0) | ||
| continue; | ||
| var amountToSkip = _logicClient.Settings.KeepMinDuplicatePokemon; | ||
| var amountPossible = familyCandy.Candy / settings.CandyToEvolve; |
There was a problem hiding this comment.
Slight snag with a possible divide by zero here by moving it out like this.
There was a problem hiding this comment.
Right the condition that was removed should not have been removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With KeepPokemonsThatCanEvolve=true it also kept all pokemons that couldn't evolve. Added KeepPokemonsThatCanEvolve to Settings