Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] catch and find lure incense pokemon #673

Merged
merged 6 commits into from
Jul 26, 2016
Merged

[Feature] catch and find lure incense pokemon #673

merged 6 commits into from
Jul 26, 2016

Conversation

bin101
Copy link
Contributor

@bin101 bin101 commented Jul 26, 2016

Catching incense pokemon should work if
AeonLucid/POGOProtos#81
is accepeted and included in the proto nuget packet.

Currently the incense encounter id is alway 0 so we dont get a valid encounter

UntilSunrise added 6 commits July 26, 2016 18:23
Lure Pokemons are working
… into patch-CatchAndFindLureIncensePkm

# Conflicts:
#	PoGo.NecroBot.CLI/ConsoleEventListener.cs
#	PoGo.NecroBot.Logic/Tasks/FarmPokestopsGPXTask.cs
… into patch-CatchAndFindLureIncensePkm

# Conflicts:
#	PoGo.NecroBot.CLI/ConsoleEventListener.cs
#	PoGo.NecroBot.Logic/Tasks/CatchPokemonTask.cs
@Ilses
Copy link
Contributor

Ilses commented Jul 26, 2016

Nice work!

@NecronomiconCoding NecronomiconCoding merged commit 2b1259a into NecronomiconCoding:master Jul 26, 2016
@Ilses
Copy link
Contributor

Ilses commented Jul 26, 2016

I clearly haven't used C# in years.. I forgot dynamic was a thing. That said, I can't help but feel the code would have been cleaner if you'd overloaded Encounter's Execute function.

@maxbrueckl
Copy link

maxbrueckl commented Jul 26, 2016

I guess there is a problem with this merge. A null pointer exception, that is happening when encounter lured pokemon.

In: CatchPokemonTask.cs:88 - pokemon is null
In: CatchLurePokemonsTask.cs:41 - Execute(_,_,_,null,_,_); is called.

I did apply a workaround:

               var pokemon = new POGOProtos.Map.Pokemon.MapPokemon
                {
                    EncounterId = encounterId,
                    ExpirationTimestampMs = currentFortData.LureInfo.LureExpiresTimestampMs,
                    Latitude = currentFortData.Latitude,
                    Longitude = currentFortData.Longitude,
                    PokemonId = pokemonId,
                    SpawnPointId = currentFortData.LureInfo.FortId
                };

...
CatchPokemonTask.Execute(ctx, machine, encounter, pokemon, currentFortData, encounterId);

@bjornegrim
Copy link
Contributor

can anyone push a fix for it? @maxbrueckl

@bin101
Copy link
Contributor Author

bin101 commented Jul 26, 2016

is fixed

@bin101 bin101 deleted the patch-CatchAndFindLureIncensePkm branch July 27, 2016 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants