-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] catch and find lure incense pokemon #673
[Feature] catch and find lure incense pokemon #673
Conversation
Lure Pokemons are working
… into patch-CatchAndFindLureIncensePkm # Conflicts: # PoGo.NecroBot.CLI/ConsoleEventListener.cs # PoGo.NecroBot.Logic/Tasks/FarmPokestopsGPXTask.cs
… into patch-CatchAndFindLureIncensePkm # Conflicts: # PoGo.NecroBot.CLI/ConsoleEventListener.cs # PoGo.NecroBot.Logic/Tasks/CatchPokemonTask.cs
Nice work! |
I clearly haven't used C# in years.. I forgot dynamic was a thing. That said, I can't help but feel the code would have been cleaner if you'd overloaded Encounter's Execute function. |
I guess there is a problem with this merge. A null pointer exception, that is happening when encounter lured pokemon. In: CatchPokemonTask.cs:88 - I did apply a workaround:
... |
can anyone push a fix for it? @maxbrueckl |
is fixed |
Catching incense pokemon should work if
AeonLucid/POGOProtos#81
is accepeted and included in the proto nuget packet.
Currently the incense encounter id is alway 0 so we dont get a valid encounter