Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: datepickerview): fix days can't select 31 #383

Merged
merged 1 commit into from
Apr 14, 2019
Merged

fix(module: datepickerview): fix days can't select 31 #383

merged 1 commit into from
Apr 14, 2019

Conversation

nuonuoge
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

Merging #383 into master will increase coverage by 0.05%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   89.25%   89.31%   +0.05%     
==========================================
  Files         229      229              
  Lines        6907     6908       +1     
  Branches      564      564              
==========================================
+ Hits         6165     6170       +5     
+ Misses        571      567       -4     
  Partials      171      171
Impacted Files Coverage Δ
...nts/date-picker-view/date-picker-view.component.ts 94.44% <50%> (-1.34%) ⬇️
components/date-picker/date-picker.component.ts 80.78% <0%> (+1.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fac2f1...ddc7056. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants