-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module: tabs&tabbar): tabs&tabbar refactor #399
Conversation
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
- Coverage 89.36% 89.15% -0.22%
==========================================
Files 320 321 +1
Lines 7093 7080 -13
Branches 568 582 +14
==========================================
- Hits 6339 6312 -27
- Misses 583 589 +6
- Partials 171 179 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- action-sheet 修改另外提交分支
- tabs.component.spec.ts 中注释测试用例对应修改或删除
- 目前api与react仍未保持一致,请再次确认,因涉及breakchange,不建议重复修改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
TabBar APIs have been changed to make it more simple.
Other information