Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: imagepicker): add capture&disableDelete API #410

Merged
merged 3 commits into from
May 5, 2019

Conversation

fisherspy
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@fisherspy fisherspy requested a review from BronzeCui May 5, 2019 02:54
@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #410 into master will decrease coverage by 3.48%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
- Coverage   89.17%   85.68%   -3.49%     
==========================================
  Files         321      321              
  Lines        7101     7711     +610     
  Branches      584     1095     +511     
==========================================
+ Hits         6332     6607     +275     
- Misses        590      665      +75     
- Partials      179      439     +260
Impacted Files Coverage Δ
components/image-picker/image-picker.component.ts 72.65% <100%> (-7.17%) ⬇️
components/core/wave/nz-wave.directive.ts 83.33% <0%> (-16.67%) ⬇️
components/core/util/touch-event.ts 66.66% <0%> (-16.67%) ⬇️
components/picker/picker.component.ts 69.69% <0%> (-12.28%) ⬇️
...ponents/core/directive/touch-feedback.component.ts 58.33% <0%> (-11.67%) ⬇️
...nents/pull-to-refresh/pull-to-refresh.component.ts 72.12% <0%> (-11.22%) ⬇️
components/picker/picker.service.ts 85% <0%> (-9.45%) ⬇️
components/core/wave/nz-wave-renderer.ts 87.5% <0%> (-8.8%) ⬇️
...ts/input-item/custom-input/custom-input.service.ts 84.84% <0%> (-8.49%) ⬇️
...ts/carousel/dotindicator/dotindicator.component.ts 75% <0%> (-8.34%) ⬇️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7d090...bc4e578. Read the comment docs.

Copy link
Contributor

@BronzeCui BronzeCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@fisherspy fisherspy merged commit cfd733e into NG-ZORRO:master May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants