Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: input-item): fix input-item bug #500

Merged
merged 3 commits into from
Jul 22, 2019

Conversation

sWhite01111
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@sWhite01111 sWhite01111 requested a review from 3fuyu July 9, 2019 08:26
@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #500 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
- Coverage   87.53%   87.51%   -0.03%     
==========================================
  Files         270      270              
  Lines        7588     7583       -5     
  Branches     1085     1083       -2     
==========================================
- Hits         6642     6636       -6     
- Misses        530      531       +1     
  Partials      416      416
Impacted Files Coverage Δ
components/input-item/input-item.component.ts 93.96% <33.33%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ade9b...23fc490. Read the comment docs.

@sWhite01111 sWhite01111 changed the title feat(module: input-item): fix input cursor bug feat(module: input-item): fix input-item bug Jul 9, 2019
@3fuyu 3fuyu merged commit 9f9f579 into NG-ZORRO:master Jul 22, 2019
@3fuyu
Copy link
Contributor

3fuyu commented Jul 22, 2019

#465

@3fuyu
Copy link
Contributor

3fuyu commented Jul 22, 2019

#496

fisherspy pushed a commit that referenced this pull request Mar 10, 2020
* feat(module: input-item): fix input cursor bug

* feat(module: input-item): hide keyboard when editable is false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants