Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: drawer): fix drawer flash back with tabs #724

Merged
merged 2 commits into from
Jul 14, 2020
Merged

fix(module: drawer): fix drawer flash back with tabs #724

merged 2 commits into from
Jul 14, 2020

Conversation

nuonuoge
Copy link
Collaborator

@nuonuoge nuonuoge commented Jul 6, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@nuonuoge nuonuoge requested a review from fisherspy July 6, 2020 06:55
@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #724 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
- Coverage   87.16%   87.14%   -0.02%     
==========================================
  Files         164      164              
  Lines        6747     6747              
  Branches     1104     1104              
==========================================
- Hits         5881     5880       -1     
  Misses        421      421              
- Partials      445      446       +1     
Impacted Files Coverage Δ
...ts/input-item/custom-input/custom-input.service.ts 83.87% <0.00%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aae09b...002588b. Read the comment docs.

@fisherspy fisherspy merged commit c4b56e0 into NG-ZORRO:master Jul 14, 2020
@nuonuoge nuonuoge deleted the fix-drawer branch July 15, 2020 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants