Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: stepper): 修复输入框输入显示问题 #791

Merged
merged 2 commits into from
May 30, 2021

Conversation

shuizhongxiong
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

手动输入除数字之外的字符,显示值会变为NaN

Issue Number: 787、771

What is the new behavior?

1、输入框增加只能输入数字的限制
2、输入框增加小数和负数的输入判断
3、输入框增加 blur 时,对输入值进行有效判断并回填
4、增加相应测试用例
5、增加 demo 示例

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #791 (c18680a) into master (1d9a4a6) will decrease coverage by 0.08%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
- Coverage   86.99%   86.91%   -0.09%     
==========================================
  Files         164      164              
  Lines        6645     6677      +32     
  Branches     1109     1115       +6     
==========================================
+ Hits         5781     5803      +22     
- Misses        421      428       +7     
- Partials      443      446       +3     
Impacted Files Coverage Δ
components/stepper/stepper.component.ts 90.85% <71.42%> (-6.12%) ⬇️
...ts/input-item/custom-input/custom-input.service.ts 87.09% <0.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d9a4a6...c18680a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants