Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:drawer): ngOnDestory may called before onInit #2037

Merged
merged 2 commits into from
Feb 25, 2019

Conversation

tonny008
Copy link
Contributor

https://www.bennadel.com/blog/3356-ngoninit-may-not-get-called-before-ngondestroy-is-called-in-angular-4-4-6.htm

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ x] No

Other information

@hsuanxyz
Copy link
Member

@tonny008
Hi thanks for your pr, please make sure your pr meet our guidelines.
https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit

@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #2037 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2037      +/-   ##
==========================================
- Coverage   95.85%   95.83%   -0.02%     
==========================================
  Files         485      485              
  Lines       12299    12300       +1     
  Branches     1671     1672       +1     
==========================================
- Hits        11789    11788       -1     
  Misses        150      150              
- Partials      360      362       +2
Impacted Files Coverage Δ
components/drawer/nz-drawer.component.ts 97.6% <50%> (-0.59%) ⬇️
components/time-picker/time-holder.ts 95.91% <0%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb8548...2507dbd. Read the comment docs.

@tonny008 tonny008 changed the title ngOnDestory may called before onInit fix(module:drawer): ngOnDestory may called before onInit Aug 27, 2018
@hsuanxyz hsuanxyz merged commit 9bf9299 into NG-ZORRO:master Feb 25, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants