Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select,tree-select): prevent pop the dropdown when click remove #2290

Merged
merged 2 commits into from
Oct 18, 2018

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2276

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

ant-design/ant-design#10274

@codecov
Copy link

codecov bot commented Oct 17, 2018

Codecov Report

Merging #2290 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2290      +/-   ##
==========================================
+ Coverage   95.89%   95.91%   +0.01%     
==========================================
  Files         485      485              
  Lines       12182    12186       +4     
  Branches     1638     1640       +2     
==========================================
+ Hits        11682    11688       +6     
+ Misses        143      142       -1     
+ Partials      357      356       -1
Impacted Files Coverage Δ
...mponents/select/nz-select-top-control.component.ts 97.72% <100%> (+0.05%) ⬆️
components/tree-select/nz-tree-select.component.ts 97.78% <100%> (+0.01%) ⬆️
components/time-picker/time-holder.ts 95.91% <0%> (-1.03%) ⬇️
components/table/nz-table.component.ts 95.55% <0%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 648da35...2275e48. Read the comment docs.

@vthinkxie vthinkxie merged commit 4fa9367 into NG-ZORRO:master Oct 18, 2018
@hsuanxyz hsuanxyz deleted the select/not-open-when-close branch October 23, 2018 10:35
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…emove (NG-ZORRO#2290)

* fix(module:select,tree-select): prevent pop the dropdown when click remove

ref:
- ant-design/ant-design#10274
- react-component/select#296
- react-component/tree-select#110

close NG-ZORRO#2276

* test(module:tree-select): fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants