Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:empty): show no empty when user pass null #2768

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 12, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

When user pass null to props like nzNotFoundContent, render nothing.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wzhudev wzhudev requested a review from vthinkxie January 12, 2019 07:34
@codecov
Copy link

codecov bot commented Jan 12, 2019

Codecov Report

Merging #2768 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2768      +/-   ##
==========================================
+ Coverage   95.57%   95.58%   +<.01%     
==========================================
  Files         515      515              
  Lines       12191    12193       +2     
  Branches     1711     1711              
==========================================
+ Hits        11652    11655       +3     
  Misses        173      173              
+ Partials      366      365       -1
Impacted Files Coverage Δ
components/empty/nz-empty-config.ts 100% <ø> (ø)
components/empty/nz-empty.component.ts 100% <100%> (ø) ⬆️
components/empty/nz-empty-error.ts 100% <100%> (ø)
components/empty/nz-embed-empty.component.ts 96.29% <100%> (-0.07%) ⬇️
components/empty/nz-empty.service.ts 100% <100%> (ø) ⬆️
components/time-picker/time-holder.ts 96.93% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 791b9b3...8eec1a2. Read the comment docs.

@netlify
Copy link

netlify bot commented Jan 13, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 8eec1a2

https://deploy-preview-2768--ng-zorro-master.netlify.com

@wzhudev wzhudev changed the title fix(module:editor): show no empty when use pass null fix(module:empty): show no empty when use pass null Jan 13, 2019
@wzhudev wzhudev changed the title fix(module:empty): show no empty when use pass null fix(module:empty): show no empty when user pass null Jan 13, 2019
@hsuanxyz hsuanxyz merged commit d037b27 into NG-ZORRO:master Jan 17, 2019
@wzhudev wzhudev deleted the empty-null branch February 18, 2019 01:13
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants