-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:input): fix type error #283
fix(module:input): fix type error #283
Conversation
duplicated #271 and it is not a bug but a hack. |
@vthinkxie Got it. Such like this: set nzAutosize(value: string | boolean | AutoSizeType) {
if (typeof value === 'string') {
this._autosize = true;
} else {
this._autosize = <boolean | AutoSizeType>value;
}
if (this._autosize) {
this._render.setAttribute(this.nativeElement, 'autosize', '');
} else {
this._render.removeAttribute(this.nativeElement, 'autosize');
}
} Is that a good way? |
@deart1mer yes, but it is strange that there is no error when I run npm run start, and CI is ok. |
e9c415b
to
92fe1c9
Compare
@vthinkxie OK :-) |
😄 I thought I was the only one who ran into this bug before this PR.... |
btw, I think autosize is ambiguity. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
#282
What is the new behavior?
Does this PR introduce a breaking change?
Other information