Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:anchor): fix called detectChanges when component destroy #2864

Merged
merged 7 commits into from
Jan 31, 2019
Merged

fix(module:anchor): fix called detectChanges when component destroy #2864

merged 7 commits into from
Jan 31, 2019

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jan 30, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2860

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jan 30, 2019

Deploy preview for ng-zorro-master ready!

Built with commit a751213

https://deploy-preview-2864--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #2864 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2864      +/-   ##
==========================================
- Coverage   95.48%   95.48%   -0.01%     
==========================================
  Files         523      523              
  Lines       12237    12239       +2     
  Branches     1668     1668              
==========================================
+ Hits        11685    11686       +1     
  Misses        198      198              
- Partials      354      355       +1
Impacted Files Coverage Δ
components/anchor/nz-anchor.component.ts 100% <100%> (ø) ⬆️
components/select/nz-option-container.component.ts 95.12% <0%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58743b8...a751213. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 0e5c937 into NG-ZORRO:master Jan 31, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants