-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:message,notification): add close event #2952
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2952 +/- ##
==========================================
+ Coverage 97.37% 97.39% +0.01%
==========================================
Files 546 546
Lines 11275 11281 +6
Branches 809 809
==========================================
+ Hits 10979 10987 +8
+ Misses 188 186 -2
Partials 108 108
Continue to review full report at Codecov.
|
Deploy preview for ng-zorro-master ready! Built with commit 0562ea2 |
3e4aa72
to
fcb661a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat(module:message, notification): add close event close NG-ZORRO#2458 * docs: fix Chinese doc not translated * fix: remove redundant declaration
* feat(module:message, notification): add close event close NG-ZORRO#2458 * docs: fix Chinese doc not translated * fix: remove redundant declaration
close #2458
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
There is a
onClose
subject on bothNzMessageDataFilled
andNzNotificationDataFilled
and aonClick
onNzMessageDataFilled
. They would emit events as their names suggest. And especially,onClose
would emit atrue
if it's closed by user.Does this PR introduce a breaking change?
Other information