Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:message,notification): add close event #2952

Merged
merged 3 commits into from
Feb 26, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Feb 22, 2019

close #2458

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

There is a onClose subject on both NzMessageDataFilled and NzNotificationDataFilled and a onClick on NzMessageDataFilled. They would emit events as their names suggest. And especially, onClose would emit a true if it's closed by user.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wzhudev wzhudev marked this pull request as ready for review February 22, 2019 07:56
@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #2952 into master will increase coverage by 0.01%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2952      +/-   ##
==========================================
+ Coverage   97.37%   97.39%   +0.01%     
==========================================
  Files         546      546              
  Lines       11275    11281       +6     
  Branches      809      809              
==========================================
+ Hits        10979    10987       +8     
+ Misses        188      186       -2     
  Partials      108      108
Impacted Files Coverage Δ
...mponents/notification/nz-notification.component.ts 100% <100%> (+6.66%) ⬆️
components/message/nz-message.component.ts 97.67% <100%> (ø) ⬆️
...mponents/message/nz-message-container.component.ts 100% <100%> (ø) ⬆️
...otification/nz-notification-container.component.ts 100% <100%> (ø) ⬆️
components/message/nz-message.service.ts 97.91% <50%> (ø) ⬆️
components/table/nz-table.component.ts 97.69% <0%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4081abb...0562ea2. Read the comment docs.

@netlify
Copy link

netlify bot commented Feb 22, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 0562ea2

https://deploy-preview-2952--ng-zorro-master.netlify.com

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit f2e45ea into NG-ZORRO:master Feb 26, 2019
@wzhudev wzhudev deleted the message-noti-event branch February 27, 2019 01:41
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:message, notification): add close event

close NG-ZORRO#2458

* docs: fix Chinese doc not translated

* fix: remove redundant declaration
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:message, notification): add close event

close NG-ZORRO#2458

* docs: fix Chinese doc not translated

* fix: remove redundant declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification 组件需要有“关闭时的回调函数”这种操作
2 participants