-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:time-picker): place ViewChild decorator on correct field #4156
Conversation
Deploy preview for ng-zorro-master ready! Built with commit 0527048 |
Codecov Report
@@ Coverage Diff @@
## master #4156 +/- ##
==========================================
+ Coverage 92.27% 92.28% +<.01%
==========================================
Files 517 517
Lines 10961 10962 +1
Branches 1985 1985
==========================================
+ Hits 10114 10116 +2
+ Misses 422 421 -1
Partials 425 425
Continue to review full report at Codecov.
|
Now possible to compile with Ivy? |
@Svetomechc no, unfortunately. There is another issue with bindings and base classes |
@lppedd what do you think the ETA on that will be? After Angular 9.0 stable release? |
@Svetomechc I have no idea as I'm not part of ng-zorro. I would hope for it being ready for 9 RC in a couple of weeks. |
This PR fixes an issue with Ivy compatibility.
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?