Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:time-picker): place ViewChild decorator on correct field #4156

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

lppedd
Copy link
Contributor

@lppedd lppedd commented Sep 12, 2019

This PR fixes an issue with Ivy compatibility.

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[X] No

@netlify
Copy link

netlify bot commented Sep 12, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 0527048

https://deploy-preview-4156--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #4156 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4156      +/-   ##
==========================================
+ Coverage   92.27%   92.28%   +<.01%     
==========================================
  Files         517      517              
  Lines       10961    10962       +1     
  Branches     1985     1985              
==========================================
+ Hits        10114    10116       +2     
+ Misses        422      421       -1     
  Partials      425      425
Impacted Files Coverage Δ
...ents/time-picker/nz-time-picker-panel.component.ts 87.78% <100%> (+0.96%) ⬆️
components/time-picker/time-holder.ts 95.61% <0%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de1e496...0527048. Read the comment docs.

@Svetomechc
Copy link
Contributor

Now possible to compile with Ivy?

@lppedd
Copy link
Contributor Author

lppedd commented Oct 17, 2019

@Svetomechc no, unfortunately. There is another issue with bindings and base classes

@Svetomechc
Copy link
Contributor

@lppedd what do you think the ETA on that will be? After Angular 9.0 stable release?

@lppedd
Copy link
Contributor Author

lppedd commented Oct 17, 2019

@Svetomechc I have no idea as I'm not part of ng-zorro. I would hope for it being ready for 9 RC in a couple of weeks.

@lppedd lppedd deleted the fix-time-picker-ivy branch October 23, 2019 19:27
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants