Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): fix select scroll bottom not emit with search #4272

Merged
merged 1 commit into from
Oct 11, 2019
Merged

fix(module:select): fix select scroll bottom not emit with search #4272

merged 1 commit into from
Oct 11, 2019

Conversation

vthinkxie
Copy link
Member

close #3777

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #4272 into master will decrease coverage by 0.03%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4272      +/-   ##
==========================================
- Coverage   92.21%   92.18%   -0.04%     
==========================================
  Files         520      520              
  Lines       10982    10986       +4     
  Branches     1990     1990              
==========================================
  Hits        10127    10127              
- Misses        427      430       +3     
- Partials      428      429       +1
Impacted Files Coverage Δ
components/select/nz-option-container.component.ts 88.88% <40%> (-7.99%) ⬇️
components/dropdown/nz-dropdown.component.ts 93.75% <0%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d90b7...d550a8a. Read the comment docs.

@netlify
Copy link

netlify bot commented Oct 11, 2019

Deploy preview for ng-zorro-master ready!

Built with commit d550a8a

https://deploy-preview-4272--ng-zorro-master.netlify.com

@vthinkxie vthinkxie merged commit e9c5541 into NG-ZORRO:master Oct 11, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scrollBottom will not trigger when select search changed
2 participants