fix(module:core): fix global config not working in prod mode #4325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit 60f7b1b |
Codecov Report
@@ Coverage Diff @@
## master #4325 +/- ##
==========================================
+ Coverage 92.15% 92.19% +0.04%
==========================================
Files 520 520
Lines 11016 11038 +22
Branches 1997 1997
==========================================
+ Hits 10152 10177 +25
+ Misses 431 429 -2
+ Partials 433 432 -1
Continue to review full report at Codecov.
|
vthinkxie
reviewed
Oct 21, 2019
| this.nzConfigService | ||
| .getConfigChangeEventForComponent(trimComponentName(this.constructor.name)) | ||
| .subscribe(() => this.setConfig()); | ||
| this.nzConfigService.getConfigChangeEventForComponent('message').subscribe(() => this.setConfig()); |
There was a problem hiding this comment.
it would better to add an NZ_CONFIG_COMPONENT_NAME like other components here
vthinkxie
reviewed
Oct 21, 2019
| @@ -64,7 +64,7 @@ export class NzNotificationContainerComponent extends NzMessageContainerComponen | |||
| const newConfig = (this.config = { | |||
| ...this.config, | |||
| ...config, | |||
| ...this.nzConfigService.getConfigForComponent(trimComponentName(this.constructor.name)) | |||
| ...this.nzConfigService.getConfigForComponent('notification') | |||
There was a problem hiding this comment.
it would better to add an NZ_CONFIG_COMPONENT_NAME like other components here
vthinkxie
reviewed
Oct 21, 2019
components/spin/nz-spin.component.ts
Outdated
| @@ -82,7 +77,7 @@ export class NzSpinComponent implements OnChanges, OnDestroy, OnInit { | |||
| this.subscribeLoading(); | |||
|
|
|||
| this.nzConfigService | |||
| .getConfigChangeEventForComponent(trimComponentName(this.constructor.name)) | |||
| .getConfigChangeEventForComponent('spin') | |||
vthinkxie
reviewed
Oct 21, 2019
| @@ -60,7 +60,7 @@ export class NzSwitchComponent implements ControlValueAccessor, AfterViewInit, O | |||
| @Input() @InputBoolean() nzControl = false; | |||
| @Input() nzCheckedChildren: string | TemplateRef<void>; | |||
| @Input() nzUnCheckedChildren: string | TemplateRef<void>; | |||
| @Input() @WithConfig('default') nzSize: NzSizeDSType; | |||
| @Input() @WithConfig('switch', 'default') nzSize: NzSizeDSType; | |||
There was a problem hiding this comment.
it would better to add an NZ_CONFIG_COMPONENT_NAME like other components here
vthinkxie
reviewed
Oct 21, 2019
| @@ -80,7 +80,7 @@ export class NzTypographyComponent implements OnInit, AfterViewInit, OnDestroy, | |||
| @Input() @InputBoolean() nzExpandable = false; | |||
| @Input() @InputBoolean() nzEllipsis = false; | |||
| @Input() nzContent: string; | |||
| @Input() @WithConfig(1) @InputNumber() nzEllipsisRows: number; | |||
| @Input() @WithConfig('typography', 1) @InputNumber() nzEllipsisRows: number; | |||
There was a problem hiding this comment.
it would better to add an NZ_CONFIG_COMPONENT_NAME like other components here
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
…O#4325) * fix(module:core): fix global config not working in prod mode * chore: cleanup code close NG-ZORRO#4319
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
…O#4325) * fix(module:core): fix global config not working in prod mode * chore: cleanup code close NG-ZORRO#4319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4319
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #4319
What is the new behavior?
Global configuration works in prod env.
Does this PR introduce a breaking change?
Other information