-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:monaco-editor): support static loading #4341
Merged
hsuanxyz
merged 5 commits into
NG-ZORRO:master
from
wzhudev:monaco-editor-webpack-loading
Nov 7, 2019
Merged
feat(module:monaco-editor): support static loading #4341
hsuanxyz
merged 5 commits into
NG-ZORRO:master
from
wzhudev:monaco-editor-webpack-loading
Nov 7, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for ng-zorro-master ready! Built with commit 650222b |
Codecov Report
@@ Coverage Diff @@
## master #4341 +/- ##
==========================================
- Coverage 92.2% 92.08% -0.12%
==========================================
Files 520 520
Lines 11039 11054 +15
Branches 1997 2001 +4
==========================================
+ Hits 10178 10179 +1
- Misses 429 443 +14
Partials 432 432
Continue to review full report at Codecov.
|
hsuanxyz
requested changes
Oct 24, 2019
hsuanxyz
approved these changes
Oct 28, 2019
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* feat(module:code-editor): support static loading * feat(module:code-editor): use global config service * docs: monaco editor * fix: fix style import path * fix: fix style import
Closed
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* feat(module:code-editor): support static loading * feat(module:code-editor): use global config service * docs: monaco editor * fix: fix style import path * fix: fix style import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information