chore(module:message,notification): remove old injection tokens #4404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzhudev
added
💔 Breaking Change
|
Deploy preview for ng-zorro-master ready! Built with commit 395dadc |
Codecov Report
@@ Coverage Diff @@
## master #4404 +/- ##
==========================================
- Coverage 93.23% 93.16% -0.08%
==========================================
Files 519 521 +2
Lines 12822 12830 +8
Branches 2013 2016 +3
==========================================
- Hits 11955 11953 -2
- Misses 452 462 +10
Partials 415 415
Continue to review full report at Codecov.
|
hsuanxyz
changed the title
wzhudev
force-pushed
the
remove-msg-noti-api
branch
2 times, most recently
from
90f8fc4 to
395dadc
Compare
BREAKING CHANGE: - `NZ_MESSAGE_CONFIG` is removed. Please use `NzGlobalConfigService` instead. - `NZ_NOTIFICATION_CONFIG` is removed. Please use `NzGlobalConfigService` instead. - `config` method of `NzMessageService` and `NzNotificationService` is removed. Please use `set` method of `NzGlobalConfigService` instead.
wzhudev
force-pushed
the
remove-msg-noti-api
branch
from
395dadc to
dd192a8
Compare
added 2 commits
December 31, 2019 20:15
hsuanxyz
approved these changes
Jan 8, 2020
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
…ORRO#4404) * chore(module:message,notification): remove old injection tokens * fix: lint * fix: fix lint * docs: fix global injection doc BREAKING CHANGE: - `NZ_MESSAGE_CONFIG` is removed. Please use `NzGlobalConfigService` instead. - `NZ_NOTIFICATION_CONFIG` is removed. Please use `NzGlobalConfigService` instead. - `config` method of `NzMessageService` and `NzNotificationService` is removed. Please use `set` method of `NzGlobalConfigService` instead.
Closed
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
…ORRO#4404) * chore(module:message,notification): remove old injection tokens * fix: lint * fix: fix lint * docs: fix global injection doc BREAKING CHANGE: - `NZ_MESSAGE_CONFIG` is removed. Please use `NzGlobalConfigService` instead. - `NZ_NOTIFICATION_CONFIG` is removed. Please use `NzGlobalConfigService` instead. - `config` method of `NzMessageService` and `NzNotificationService` is removed. Please use `set` method of `NzGlobalConfigService` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Injection tokens such as
NZ_MESSAGE_CONFIGare now removed. Users should useNzConfigServiceinstead.Does this PR introduce a breaking change?
Other information