Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(module:calendar): delete deprecated input nzCard #4464

Merged
merged 2 commits into from
Nov 22, 2019
Merged

chore(module:calendar): delete deprecated input nzCard #4464

merged 2 commits into from
Nov 22, 2019

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Nov 22, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@wenqi73 wenqi73 requested a review from hsuanxyz November 22, 2019 07:41
@zorro-bot
Copy link

zorro-bot bot commented Nov 22, 2019

This preview will be available after the checks is complete.

@auto-assign auto-assign bot requested a review from simplejason November 22, 2019 07:41
@hsuanxyz hsuanxyz added PR: target-major 💔 Breaking Change This PR or the solution to this issue would introduce breaking changes labels Nov 22, 2019
@codecov
Copy link

codecov bot commented Nov 22, 2019 •
edited
Loading

Codecov Report

Merging #4464 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4464      +/-   ##
==========================================
+ Coverage   91.99%   91.99%   +<.01%     
==========================================
  Files         518      518              
  Lines       11014    11010       -4     
  Branches     2005     2005              
==========================================
- Hits        10132    10129       -3     
+ Misses        452      451       -1     
  Partials      430      430
Impacted Files Coverage Δ
components/calendar/nz-calendar.component.ts 100% <ø> (ø) ⬆️
components/typography/nz-typography.component.ts 98.97% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac43c6...7c71de7. Read the comment docs.

@netlify
Copy link

netlify bot commented Nov 22, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 7c71de7

https://deploy-preview-4464--ng-zorro-master.netlify.com

wzhudev
wzhudev approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit aed2e7d into NG-ZORRO:master Nov 22, 2019
@wenqi73 wenqi73 deleted the calendar-nzcard branch January 9, 2020 03:37
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@wenqi73 @Ricbet
chore(module:calendar): delete deprecated input nzCard (NG-ZORRO#4464)
b10c87b 
* chore(module:calendar): delete deprecated input nzCard

* fix: tslint

BREAKING CHANGE: `<nz-calendar>` `nzCard` input has been removed, use `nzFullscreen` instead.
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
Closed
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@wenqi73 @hsuanxyz
chore(module:calendar): delete deprecated input nzCard (NG-ZORRO#4464)
075b56c 
* chore(module:calendar): delete deprecated input nzCard

* fix: tslint

BREAKING CHANGE: `<nz-calendar>` `nzCard` input has been removed, use `nzFullscreen` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@hsuanxyz hsuanxyz Awaiting requested review from hsuanxyz

@simplejason simplejason Awaiting requested review from simplejason

Assignees

@simplejason simplejason

Labels
💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: merged PR: target-major PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wenqi73 @wzhudev @simplejason @hsuanxyz