Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): select date but nzDefaultOpenValue not work #4490

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Nov 30, 2019

Close #4454

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Nov 30, 2019

This preview will be available after the checks is complete.

@auto-assign auto-assign bot requested a review from cipchk November 30, 2019 04:47
@netlify
Copy link

netlify bot commented Nov 30, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 4e1247a

https://deploy-preview-4490--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Nov 30, 2019

Codecov Report

Merging #4490 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4490      +/-   ##
==========================================
+ Coverage   92.02%   92.02%   +<.01%     
==========================================
  Files         517      517              
  Lines       10922    10923       +1     
  Branches     1981     1983       +2     
==========================================
+ Hits        10051    10052       +1     
  Misses        448      448              
  Partials      423      423
Impacted Files Coverage Δ
components/core/time/candy-date.ts 84.94% <100%> (-0.32%) ⬇️
...ts/date-picker/lib/popups/inner-popup.component.ts 96% <100%> (+0.54%) ⬆️
components/time-picker/time-holder.ts 97.36% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f72e67...4e1247a. Read the comment docs.

@wenqi73 wenqi73 requested a review from wzhudev November 30, 2019 06:15
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 2397819 into NG-ZORRO:master Dec 2, 2019
@wenqi73 wenqi73 deleted the fix-default-value branch January 9, 2020 03:37
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nzshowtime 的 nzDefaultOpenValue 在 nz-range-picker 无效, nz-date-picker 只有先选时间才有效
4 participants