Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schematics): add v9 migration rules for tree #4602

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@hsuanxyz hsuanxyz force-pushed the schematics/migration-v9-tree branch from d02ee1d to bc48ecd Compare April 14, 2020 01:47
@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #4602 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4602   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files         549      549           
  Lines       13760    13760           
  Branches     2050     2122   +72     
=======================================
  Hits        12579    12579           
  Misses        717      717           
  Partials      464      464           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc87537...bc48ecd. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsuanxyz hsuanxyz merged commit 87b8e55 into NG-ZORRO:master Apr 14, 2020
@pr-triage pr-triage bot added the PR: merged label Apr 14, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants