Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:progress): support steps #4637

Merged
merged 3 commits into from
Jan 8, 2020
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 6, 2020

close #4635

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 6, 2020

This preview will be available after the TravisCI is passed.

@wzhudev wzhudev requested a review from hsuanxyz January 6, 2020 10:32
@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #4637 into master will decrease coverage by 0.07%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4637      +/-   ##
==========================================
- Coverage   93.23%   93.16%   -0.08%     
==========================================
  Files         519      523       +4     
  Lines       12822    12856      +34     
  Branches     2013     2021       +8     
==========================================
+ Hits        11955    11977      +22     
- Misses        452      461       +9     
- Partials      415      418       +3
Impacted Files Coverage Δ
components/progress/nz-progress.component.ts 95.12% <93.33%> (-0.3%) ⬇️
components/select/nz-option-container.component.ts 76.19% <0%> (-14.29%) ⬇️
components/table/nz-th.component.ts 98.16% <0%> (-1.84%) ⬇️
...ents/time-picker/nz-time-picker-panel.component.ts 92.88% <0%> (-1.19%) ⬇️
components/carousel/nz-carousel.component.ts 93.15% <0%> (-0.23%) ⬇️
components/code-editor/nz-code-editor.component.ts 17.89% <0%> (-0.2%) ⬇️
components/progress/nz-progress.module.ts 100% <0%> (ø) ⬆️
components/empty/nz-embed-empty.component.ts 95.83% <0%> (ø) ⬆️
components/table/nz-table.component.ts 93.16% <0%> (ø) ⬆️
components/ng-zorro-antd.module.ts 33.33% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 137337e...80b47d0. Read the comment docs.

@hsuanxyz hsuanxyz merged commit fe8b469 into NG-ZORRO:master Jan 8, 2020
@wzhudev wzhudev deleted the progress-step branch January 8, 2020 11:21
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:progress): support steps

* test: add test
* chore: remove console

close NG-ZORRO#4635
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:progress): support steps

* test: add test
* chore: remove console

close NG-ZORRO#4635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Progress] support steps property
3 participants