Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:breadcrumb): support indenpendent separator #4713

Merged
merged 3 commits into from
Feb 28, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 22, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 22, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #4713 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4713      +/-   ##
==========================================
+ Coverage   93.18%   93.18%   +<.01%     
==========================================
  Files         501      502       +1     
  Lines       12750    12751       +1     
  Branches     1957     1957              
==========================================
+ Hits        11881    11882       +1     
  Misses        457      457              
  Partials      412      412
Impacted Files Coverage Δ
components/breadcrumb/breadcrumb-item.component.ts 100% <ø> (ø)
components/breadcrumb/breadcrumb.module.ts 100% <ø> (ø)
...nents/breadcrumb/breadcrumb-separator.component.ts 100% <100%> (ø)
components/breadcrumb/breadcrumb.component.ts 84.78% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5016e4...a2e8b44. Read the comment docs.

@hsuanxyz
Copy link
Member

@wendellhu95 Rebase 一下

@hsuanxyz hsuanxyz merged commit 1f490e9 into NG-ZORRO:master Feb 28, 2020
@wzhudev wzhudev deleted the breadcrumb-9.0 branch February 29, 2020 01:26
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* chore(module:breadcrumb): refactor breadcrumb

* feat(module:breadcrumb): add independent separator component

* fix: fix new component not exported
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* chore(module:breadcrumb): refactor breadcrumb

* feat(module:breadcrumb): add independent separator component

* fix: fix new component not exported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants