Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:pipes): add pipes #4812

Merged
merged 8 commits into from
Sep 22, 2020
Merged

feat(module:pipes): add pipes #4812

merged 8 commits into from
Sep 22, 2020

Conversation

chensimeng
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Feb 24, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #4812 into master will increase coverage by 0.09%.
The diff coverage is 87.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4812      +/-   ##
==========================================
+ Coverage   90.18%   90.27%   +0.09%     
==========================================
  Files         455      463       +8     
  Lines       13840    13822      -18     
  Branches     2184     2179       -5     
==========================================
- Hits        12481    12478       -3     
+ Misses        836      823      -13     
+ Partials      523      521       -2     
Impacted Files Coverage Δ
components/core/pipe/nz-pipe.module.ts 100.00% <ø> (ø)
components/modal/modal.module.ts 100.00% <ø> (ø)
components/statistic/statistic.module.ts 100.00% <ø> (ø)
components/pipes/nz-ellipsis.pipe.ts 62.50% <62.50%> (ø)
components/pipes/nz-aggregate.pipe.ts 69.23% <69.23%> (ø)
components/pipes/nz-sanitizer.pipe.ts 80.00% <80.00%> (ø)
components/pipes/nz-bytes.pipe.ts 96.00% <96.00%> (ø)
components/core/util/number.ts 100.00% <100.00%> (ø)
components/pipes/nz-css-unit.pipe.ts 100.00% <100.00%> (ø)
components/pipes/nz-pipes.module.ts 100.00% <100.00%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b215efa...85c53ec. Read the comment docs.

@hsuanxyz hsuanxyz changed the title feat(module:core): add pipe module feat(module:pipe): add pipes Sep 17, 2020
@hsuanxyz hsuanxyz changed the title feat(module:pipe): add pipes feat(module:pipes): add pipes Sep 17, 2020
@chensimeng chensimeng requested a review from wzhudev as a code owner September 17, 2020 02:27
@chensimeng chensimeng requested a review from wenqi73 as a code owner September 17, 2020 13:00
@wenqi73 wenqi73 force-pushed the pipes branch 3 times, most recently from 9ae3325 to f1d107e Compare September 18, 2020 02:17
@hsuanxyz hsuanxyz merged commit e03e65b into NG-ZORRO:master Sep 22, 2020
@github-actions
Copy link

github-actions bot commented Sep 22, 2020

😭 Deploy PR Preview e03e65b failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants