Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:time-picker): ngModelChange not work #4944

Merged
merged 2 commits into from
Mar 26, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Mar 26, 2020

Fixes #4943

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #4944 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4944   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         535      535           
  Lines       13686    13686           
  Branches     2043     2043           
=======================================
  Hits        12528    12528           
  Misses        694      694           
  Partials      464      464           
Impacted Files Coverage Δ
...ponents/time-picker/time-picker-panel.component.ts 93.60% <ø> (+0.75%) ⬆️
components/time-picker/time-picker.component.ts 93.81% <ø> (ø)
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4d87c3...ee2331a. Read the comment docs.

@wenqi73 wenqi73 merged commit a6ecdb9 into NG-ZORRO:master Mar 26, 2020
@wenqi73 wenqi73 deleted the fix-timpicker branch March 26, 2020 07:49
@pr-triage pr-triage bot added the PR: merged label Mar 26, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* fix(module:time-picker): ngModelChange not work

* fix: update typescirpt version
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix(module:time-picker): ngModelChange not work

* fix: update typescirpt version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timepicker ngModelChange didn't trigger the event.
3 participants