Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:modal): nzModalFooter not work when the modal open on init #4954

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

hsuanxyz
Copy link
Member

close #4948

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4948

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #4954 into master will increase coverage by 0.03%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4954      +/-   ##
==========================================
+ Coverage   91.55%   91.59%   +0.03%     
==========================================
  Files         535      535              
  Lines       13688    13687       -1     
  Branches     2043     2044       +1     
==========================================
+ Hits        12532    12536       +4     
+ Misses        693      687       -6     
- Partials      463      464       +1     
Impacted Files Coverage Δ
components/modal/modal.component.ts 96.84% <71.42%> (+2.05%) ⬆️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/table/src/table/tr-measure.component.ts 100.00% <0.00%> (+13.04%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a2594...ff8962f. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the fix/modal-footer-init branch from eb1ba40 to ff8962f Compare March 30, 2020 09:55
@vthinkxie vthinkxie merged commit 2f400e8 into NG-ZORRO:master Apr 2, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directive: nzModalFooter does not work
3 participants