Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): fix nzDropdownMatchSelectWidth not work #5066

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

vthinkxie
Copy link
Member

close #5058

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 17, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #5066 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5066      +/-   ##
==========================================
+ Coverage   91.47%   91.48%   +0.01%     
==========================================
  Files         550      550              
  Lines       13740    13741       +1     
  Branches     2122     2122              
==========================================
+ Hits        12568    12571       +3     
+ Misses        710      709       -1     
+ Partials      462      461       -1     
Impacted Files Coverage Δ
...ore/transition-patch/transition-patch.directive.ts 93.33% <ø> (ø)
components/spin/spin.component.ts 100.00% <ø> (ø)
components/select/option-container.component.ts 90.90% <100.00%> (+0.28%) ⬆️
components/select/select.component.ts 90.53% <100.00%> (ø)
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867dc87...335f589. Read the comment docs.

hsuanxyz
hsuanxyz previously approved these changes Apr 17, 2020
@vthinkxie vthinkxie force-pushed the fix-select-match-width branch from 97f714b to 335f589 Compare April 17, 2020 11:09
@vthinkxie vthinkxie merged commit d210f4d into NG-ZORRO:master Apr 17, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nzDropdownMatchSelectWidth won't work for Select component anymore
3 participants