Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:auto-complete): dropdown position error with group-input #5157

Merged
merged 1 commit into from
Apr 26, 2020

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 26, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #5157 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5157      +/-   ##
==========================================
+ Coverage   91.41%   91.45%   +0.03%     
==========================================
  Files         547      547              
  Lines       13790    13793       +3     
  Branches     2148     2149       +1     
==========================================
+ Hits        12606    12614       +8     
+ Misses        713      708       -5     
  Partials      471      471              
Impacted Files Coverage Δ
components/auto-complete/autocomplete.module.ts 100.00% <ø> (ø)
components/input/input.module.ts 100.00% <ø> (ø)
...ts/auto-complete/autocomplete-trigger.directive.ts 95.78% <100.00%> (+0.02%) ⬆️
components/input/input-group.component.ts 100.00% <100.00%> (ø)
components/table/src/table/tr-measure.component.ts 100.00% <0.00%> (+13.04%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfbbf7...83befb8. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the fix/autocomplete-in-gruop branch from 487964f to 832fa9a Compare April 26, 2020 08:52
@hsuanxyz hsuanxyz force-pushed the fix/autocomplete-in-gruop branch from 832fa9a to 83befb8 Compare April 26, 2020 08:59
@hsuanxyz hsuanxyz marked this pull request as draft April 26, 2020 09:35
@hsuanxyz hsuanxyz marked this pull request as ready for review April 26, 2020 09:35
@hsuanxyz hsuanxyz closed this Apr 26, 2020
@hsuanxyz hsuanxyz reopened this Apr 26, 2020
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit 5b26479 into NG-ZORRO:master Apr 26, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants