Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:space): support nzAlign #5299

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented May 18, 2020

This preview will be available after the AzureCI is passed.

@vthinkxie
Copy link
Member

we will check this after #5414 merged

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #5299 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5299      +/-   ##
==========================================
+ Coverage   90.01%   90.04%   +0.02%     
==========================================
  Files         455      455              
  Lines       13854    13855       +1     
  Branches     2266     2267       +1     
==========================================
+ Hits        12471    12476       +5     
+ Misses        856      851       -5     
- Partials      527      528       +1     
Impacted Files Coverage Δ
components/space/space.component.ts 100.00% <100.00%> (ø)
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/table/src/table/tr-measure.component.ts 100.00% <0.00%> (+13.63%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f2d816...7ee6f2a. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 2febb92 into NG-ZORRO:master Sep 14, 2020
@hsuanxyz hsuanxyz deleted the feat/space-align branch September 14, 2020 02:22
@github-actions
Copy link

github-actions bot commented Sep 14, 2020

😭 Deploy PR Preview 2febb92 failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants