Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): get input width before panel open #5357

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Jun 1, 2020

Fixes #5320

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jun 1, 2020

This preview will be available after the AzureCI is passed.

@wenqi73 wenqi73 force-pushed the dp-bar-in-modal branch from a43e966 to 3932ba1 Compare June 1, 2020 02:43
@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #5357 into master will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5357   +/-   ##
=======================================
  Coverage   91.35%   91.36%           
=======================================
  Files         551      551           
  Lines       13909    13909           
  Branches     2099     2099           
=======================================
+ Hits        12707    12708    +1     
  Misses        712      712           
+ Partials      490      489    -1     
Impacted Files Coverage Δ
components/date-picker/picker.component.ts 95.65% <50.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e563af...089f69c. Read the comment docs.

@wenqi73 wenqi73 force-pushed the dp-bar-in-modal branch from 3932ba1 to 089f69c Compare June 1, 2020 06:41
@hsuanxyz hsuanxyz merged commit 39a6c28 into NG-ZORRO:master Jun 5, 2020
@wenqi73 wenqi73 deleted the dp-bar-in-modal branch July 8, 2020 08:48
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在modal组件中使用rang picker组件 样式有一点点小问题
2 participants