Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:notification): fix issue 4787 #5382

Merged
merged 2 commits into from
Jun 11, 2020
Merged

fix(module:notification): fix issue 4787 #5382

merged 2 commits into from
Jun 11, 2020

Conversation

fengpeng
Copy link
Contributor

@fengpeng fengpeng commented Jun 5, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 4787

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@fengpeng fengpeng requested a review from wzhudev as a code owner June 5, 2020 07:49
@zorro-bot
Copy link

zorro-bot bot commented Jun 5, 2020

This preview will be available after the AzureCI is passed.

@fengpeng fengpeng mentioned this pull request Jun 5, 2020
Closed
@wzhudev
Copy link
Member

wzhudev commented Jun 5, 2020

@fengpeng Thanks for the submission. Could you please add a test for it?

@fengpeng
Copy link
Contributor Author

fengpeng commented Jun 6, 2020

@wendellhu95 It's done ^^

@codecov
Copy link

codecov bot commented Jun 6, 2020

Codecov Report

Merging #5382 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5382   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         551      551           
  Lines       13910    13911    +1     
  Branches     2099     2099           
=======================================
+ Hits        12709    12710    +1     
  Misses        712      712           
  Partials      489      489
Impacted Files Coverage Δ
...s/notification/notification-container.component.ts 94.33% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0a25ce...6a77926. Read the comment docs.

vthinkxie
vthinkxie approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit 7217097 into NG-ZORRO:master Jun 11, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@fengpeng
fix(module:notification): fix notification template not updated (NG-Z…
2b65f95 
…ORRO#5382)

* fix(module:notification): fix issue 4787

* test(module:notification): fix issue 4787

Co-authored-by: 冯鹏 <fengpeng@qianxin.com>
close NG-ZORRO#4787
@fengpeng fengpeng deleted the fix-issue-4787 branch July 27, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vthinkxie vthinkxie vthinkxie approved these changes

@wzhudev wzhudev Awaiting requested review from wzhudev

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fengpeng @wzhudev @vthinkxie