Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:table): fix scroll bar displays always even unnecessary #5405

Closed

Conversation

andrew-yangy
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Table scroll bar is always displayed even when it's unnecessary
image

Issue Number: N/A

What is the new behavior?

Only showing scroll bar when needed.
image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jun 11, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #5405 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5405      +/-   ##
==========================================
- Coverage   91.37%   91.33%   -0.04%     
==========================================
  Files         551      551              
  Lines       13949    13949              
  Branches     2110     2110              
==========================================
- Hits        12746    12741       -5     
- Misses        712      717       +5     
  Partials      491      491              
Impacted Files Coverage Δ
...ts/table/src/table/table-inner-scroll.component.ts 80.59% <0.00%> (ø)
components/table/src/table/tbody.component.ts 85.71% <0.00%> (-14.29%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-13.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b17df2...1ed1d0b. Read the comment docs.

@vthinkxie
Copy link
Member

hi @ddvkid
we will check this after #5414 merged, thanks for your PR

@vthinkxie
Copy link
Member

there are some other style need to update
ref #5794
thanks to your PR anyway!

vthinkxie pushed a commit to vthinkxie/ng-zorro-antd that referenced this pull request Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants