Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tooltip,*): enable cdk push #5542

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jul 10, 2020

close #1825

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jul 10, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #5542 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5542   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files         454      454           
  Lines       13952    13952           
  Branches     2219     2219           
=======================================
  Hits        12724    12724           
  Misses        724      724           
  Partials      504      504           
Impacted Files Coverage Δ
components/popconfirm/popconfirm.ts 100.00% <ø> (ø)
components/popover/popover.ts 95.65% <ø> (ø)
components/tooltip/tooltip.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d44d2e...04d2770. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit 55ec1cd into NG-ZORRO:master Jul 12, 2020
@wzhudev
Copy link
Member Author

wzhudev commented Jul 15, 2020

突然想到这个 PR 合进去之后箭头的位置可能会对不齐,不过 antd 的 CSS 也没有给箭头的位置留下自由调整的余地,得我们自己去 patch

hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@wzhudev wzhudev deleted the tooltip-push branch September 18, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover placement
2 participants