Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:form): optimize code to increase robustness #5550

Merged
merged 1 commit into from
Jul 13, 2020
Merged

fix(module:form): optimize code to increase robustness #5550

merged 1 commit into from
Jul 13, 2020

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jul 12, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #5550 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5550      +/-   ##
==========================================
- Coverage   91.22%   91.19%   -0.03%     
==========================================
  Files         454      454              
  Lines       13953    13954       +1     
  Branches     2219     2219              
==========================================
- Hits        12728    12726       -2     
- Misses        719      720       +1     
- Partials      506      508       +2     
Impacted Files Coverage Δ
components/form/form-control.component.ts 94.26% <0.00%> (-0.82%) ⬇️
components/form/form.directive.ts 100.00% <100.00%> (ø)
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55ec1cd...5e82c70. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit fdf085b into NG-ZORRO:master Jul 13, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@danranVm danranVm deleted the fix-form branch October 24, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants