Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tabs): fix dropdown style #5659

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Aug 8, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@hsuanxyz hsuanxyz requested a review from NearZXH as a code owner August 8, 2020 11:20
@zorro-bot
Copy link

zorro-bot bot commented Aug 8, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 8, 2020

Codecov Report

Merging #5659 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5659      +/-   ##
==========================================
+ Coverage   90.06%   90.07%   +0.01%     
==========================================
  Files         455      455              
  Lines       13798    13798              
  Branches     2183     2183              
==========================================
+ Hits        12427    12429       +2     
+ Misses        846      844       -2     
  Partials      525      525              
Impacted Files Coverage Δ
components/tabs/tab-nav-operation.component.ts 62.06% <ø> (ø)
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/tabs/tab-nav-bar.component.ts 82.33% <0.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47050b0...67ffd86. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the fix/tabs-dropdown-style branch from 76299c7 to 67ffd86 Compare August 14, 2020 04:27
@vthinkxie vthinkxie merged commit 8415a70 into NG-ZORRO:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants