Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tabs): router link content projection error #5663

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Aug 10, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@hsuanxyz hsuanxyz requested a review from NearZXH as a code owner August 10, 2020 11:25
@hsuanxyz hsuanxyz force-pushed the fix/tabs-link branch 2 times, most recently from 8484164 to 18da234 Compare August 13, 2020 06:28
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #5663 into master will decrease coverage by 0.22%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5663      +/-   ##
==========================================
- Coverage   90.31%   90.08%   -0.23%     
==========================================
  Files         455      455              
  Lines       13788    13798      +10     
  Branches     2258     2182      -76     
==========================================
- Hits        12452    12430      -22     
- Misses        819      844      +25     
- Partials      517      524       +7     
Impacted Files Coverage Δ
components/tabs/tab.component.ts 92.59% <0.00%> (ø)
components/tabs/tabs.module.ts 100.00% <ø> (ø)
components/tabs/tab-link.directive.ts 37.50% <28.57%> (-62.50%) ⬇️
components/tabs/tabset.component.ts 86.54% <80.00%> (-9.86%) ⬇️
components/tabs/tabs-ink-bar.directive.ts 83.87% <0.00%> (-3.23%) ⬇️
components/tabs/tab-nav-bar.component.ts 82.33% <0.00%> (-2.48%) ⬇️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5899ad...02270bc. Read the comment docs.

@vthinkxie vthinkxie merged commit 47050b0 into NG-ZORRO:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants