Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:carousel): support SSR #5671

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 13, 2020

close #4292

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes, all custom strategies should add the forth parameter to their constructors
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Aug 13, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #5671 into master will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5671      +/-   ##
==========================================
- Coverage   90.07%   90.05%   -0.02%     
==========================================
  Files         455      455              
  Lines       13856    13862       +6     
  Branches     2267     2269       +2     
==========================================
+ Hits        12481    12484       +3     
- Misses        848      850       +2     
- Partials      527      528       +1     
Impacted Files Coverage Δ
components/carousel/strategies/base-strategy.ts 83.33% <69.23%> (-7.58%) ⬇️
components/carousel/carousel.component.ts 93.70% <100.00%> (+1.29%) ⬆️
...mponents/carousel/strategies/transform-strategy.ts 89.88% <100.00%> (ø)
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2febb92...3566929. Read the comment docs.

@hsuanxyz hsuanxyz added this to the NG-ZORRO v10.0.0 milestone Sep 10, 2020
@hsuanxyz
Copy link
Member

@wendellhu95 rebase

@hsuanxyz hsuanxyz merged commit 65b44aa into NG-ZORRO:master Sep 14, 2020
@github-actions
Copy link

github-actions bot commented Sep 14, 2020

😭 Deploy PR Preview 65b44aa failed. Build logs

🤖 By surge-preview

@wzhudev wzhudev deleted the fix/carousel-ssr branch September 23, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-carousel breaks SSR (Angular universal)
2 participants