Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tabs): fix clickable area of tab-link #5708

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

hsuanxyz
Copy link
Member

close #5696

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #5708 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5708   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files         455      455           
  Lines       13798    13797    -1     
  Branches     2183     2183           
=======================================
  Hits        12431    12431           
+ Misses        843      842    -1     
  Partials      524      524           
Impacted Files Coverage Δ
components/tabs/tabset.component.ts 87.05% <ø> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af91b9b...f1e60dd. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 57962e1 into NG-ZORRO:master Sep 7, 2020
@hsuanxyz hsuanxyz deleted the fix/tabs-link-area branch September 7, 2020 08:50
@github-actions
Copy link

github-actions bot commented Sep 7, 2020

😭 Deploy PR Preview 57962e1 failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tabs] not enough click area on nz-tabset[nzLinkRouter]
1 participant