Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): cursor abnormal in nz-select with nzDisabled #5716

Merged
merged 2 commits into from
Sep 10, 2020
Merged

fix(module:select): cursor abnormal in nz-select with nzDisabled #5716

merged 2 commits into from
Sep 10, 2020

Conversation

Eve-Sama
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5709

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Eve-Sama
Copy link
Contributor Author

image

上图是 #5709 issue所提供的复现场景的计算属性, 显示cursor的not-allowedtext覆盖了. 显然当nzDisabledtrue时不应该添加这个样式, 所以我在[class.ant-select-show-search]的判断上增加了nzDisabled的判断.

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #5716 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5716      +/-   ##
==========================================
- Coverage   90.09%   90.07%   -0.03%     
==========================================
  Files         455      455              
  Lines       13798    13798              
  Branches     2183     2183              
==========================================
- Hits        12431    12428       -3     
- Misses        843      844       +1     
- Partials      524      526       +2     
Impacted Files Coverage Δ
components/select/select.component.ts 87.50% <ø> (ø)
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/time-picker/time-holder.ts 94.73% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af91b9b...3a6b710. Read the comment docs.

@Eve-Sama Eve-Sama changed the title fix: cursor abnormal under nz-select with nzDisabled fix(module:select): cursor abnormal in nz-select with nzDisabled Aug 25, 2020
Copy link
Contributor

@DepickereSven DepickereSven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in Firefox, Chrome and Safari

@vthinkxie vthinkxie merged commit 0d1f027 into NG-ZORRO:master Sep 10, 2020
@github-actions
Copy link

github-actions bot commented Sep 10, 2020

🎊 PR Preview 0d1f027 has been successfully built and deployed to https://NG-ZORRO-ng-zorro-antd-preview-pr-5716.surge.sh

🕐 Build time: 1856.867s

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants