Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:mention): not emit (nzOnSearchChange) when value is empty #5729

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

hsuanxyz
Copy link
Member

close #5722

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5722

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #5729 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5729   +/-   ##
=======================================
  Coverage   90.06%   90.07%           
=======================================
  Files         455      455           
  Lines       13827    13827           
  Branches     2183     2183           
=======================================
+ Hits        12453    12454    +1     
  Misses        847      847           
+ Partials      527      526    -1     
Impacted Files Coverage Δ
components/mention/mention.component.ts 98.79% <100.00%> (ø)
components/time-picker/time-holder.ts 95.78% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b018887...4a6a662. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 4cc14ba into NG-ZORRO:master Sep 10, 2020
@hsuanxyz hsuanxyz deleted the fix/mention-emit-empty branch September 10, 2020 02:17
@github-actions
Copy link

github-actions bot commented Sep 10, 2020

😭 Deploy PR Preview 4cc14ba failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention提及中nzSuggestions无法做到动态更新
1 participant