Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree-select): should be not clearable when disabled or unselected #5769

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

hsuanxyz
Copy link
Member

close #5603

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5603

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #5769 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5769      +/-   ##
==========================================
- Coverage   90.07%   90.07%   -0.01%     
==========================================
  Files         455      455              
  Lines       13856    13862       +6     
  Branches     2267     2269       +2     
==========================================
+ Hits        12481    12486       +5     
- Misses        848      849       +1     
  Partials      527      527              
Impacted Files Coverage Δ
components/tree-select/tree-select.component.ts 93.46% <ø> (ø)
components/carousel/strategies/base-strategy.ts 83.33% <0.00%> (-7.58%) ⬇️
...mponents/carousel/strategies/transform-strategy.ts 89.88% <0.00%> (ø)
components/carousel/carousel.component.ts 93.70% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2febb92...3fa7b36. Read the comment docs.

@hsuanxyz hsuanxyz merged commit baede4a into NG-ZORRO:master Sep 14, 2020
@hsuanxyz hsuanxyz deleted the fix/tree-select-clear branch September 14, 2020 08:31
@github-actions
Copy link

github-actions bot commented Sep 14, 2020

😭 Deploy PR Preview baede4a failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select-tree 在disabled和空值的情况下也会显示 clear icon
1 participant