Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:time-picker): input value change not work #5770

Merged
merged 2 commits into from
Sep 22, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Sep 14, 2020

Closes #5678
Closes #5741
Closes #4934

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #5770 into master will decrease coverage by 0.04%.
The diff coverage is 77.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5770      +/-   ##
==========================================
- Coverage   90.27%   90.23%   -0.05%     
==========================================
  Files         455      456       +1     
  Lines       13824    13847      +23     
  Branches     2180     2183       +3     
==========================================
+ Hits        12480    12495      +15     
- Misses        822      830       +8     
  Partials      522      522              
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 95.58% <ø> (ø)
components/date-picker/picker.component.ts 97.26% <0.00%> (+0.68%) ⬆️
components/i18n/date-config.ts 100.00% <ø> (ø)
components/time-picker/time-picker.module.ts 100.00% <ø> (ø)
...ponents/time-picker/time-picker-panel.component.ts 89.71% <33.33%> (+0.32%) ⬆️
components/time-picker/time-picker.component.ts 86.99% <71.79%> (-6.56%) ⬇️
components/core/time/time-parser.ts 81.81% <81.81%> (ø)
components/i18n/date-helper.service.ts 87.87% <87.50%> (+2.87%) ⬆️
components/date-picker/testing/util.ts 77.77% <0.00%> (-22.23%) ⬇️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5159900...9e31c69. Read the comment docs.

@wenqi73 wenqi73 force-pushed the fix/time-picker-input branch 5 times, most recently from 0ba156a to a2aa645 Compare September 14, 2020 10:02
@wenqi73 wenqi73 requested a review from hsuanxyz September 14, 2020 12:31
@wenqi73 wenqi73 force-pushed the fix/time-picker-input branch from a2aa645 to db4f4d1 Compare September 14, 2020 12:52
components/i18n/date-helper.service.ts Outdated Show resolved Hide resolved
@wenqi73 wenqi73 force-pushed the fix/time-picker-input branch 3 times, most recently from b35ef63 to 0b1af92 Compare September 17, 2020 09:47
@wenqi73 wenqi73 force-pushed the fix/time-picker-input branch from 0b1af92 to 9e31c69 Compare September 17, 2020 09:48
@hsuanxyz hsuanxyz merged commit 31ca2da into NG-ZORRO:master Sep 22, 2020
@github-actions
Copy link

github-actions bot commented Sep 22, 2020

😭 Deploy PR Preview 31ca2da failed. Build logs

🤖 By surge-preview

@wenqi73 wenqi73 deleted the fix/time-picker-input branch January 27, 2021 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants