Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:upload): remove deprecated APIs for v10 #5774

Merged
merged 2 commits into from
Sep 15, 2020

Conversation

hsuanxyz
Copy link
Member

BREAKING CHANGES:

  • UploadType has been removed, use NzUploadType instead.
  • UploadListType has been removed, use NzUploadListType instead.
  • UploadFile has been removed, use NzUploadFile instead.
  • UploadChangeParam has been removed, use NzUploadChangeParam instead.
  • ShowUploadListInterface has been removed, use NzShowUploadList instead.
  • UploadTransformFileType has been removed, use NzUploadTransformFileType instead.
  • UploadXHRArgs has been removed, use NzUploadXHRArgs instead.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

BREAKING CHANGES:
- `UploadType` has been removed, use `NzUploadType` instead.
- `UploadListType` has been removed, use `NzUploadListType` instead.
- `UploadFile` has been removed, use `NzUploadFile` instead.
- `UploadChangeParam` has been removed, use `NzUploadChangeParam` instead.
- `ShowUploadListInterface` has been removed, use `NzShowUploadList` instead.
- `UploadTransformFileType` has been removed, use `NzUploadTransformFileType` instead.
- `UploadXHRArgs` has been removed, use `NzUploadXHRArgs` instead.
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #5774 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5774      +/-   ##
==========================================
+ Coverage   90.05%   90.07%   +0.01%     
==========================================
  Files         455      455              
  Lines       13859    13859              
  Branches     2189     2189              
==========================================
+ Hits        12481    12483       +2     
+ Misses        851      850       -1     
+ Partials      527      526       -1     
Impacted Files Coverage Δ
components/skeleton/skeleton.component.ts 100.00% <ø> (ø)
components/tabs/tab-nav-bar.component.ts 82.33% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a86dedc...a48fe6a. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the chore/deprecated-upload branch from 57396f6 to a48fe6a Compare September 15, 2020 05:05
@hsuanxyz hsuanxyz merged commit 9f5baae into NG-ZORRO:master Sep 15, 2020
@hsuanxyz hsuanxyz deleted the chore/deprecated-upload branch September 15, 2020 06:02
@github-actions
Copy link

github-actions bot commented Sep 15, 2020

😭 Deploy PR Preview 9f5baae failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant