Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:anchor): remove deprecated APIs for v10 #5776

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

hsuanxyz
Copy link
Member

BREAKING CHANGES:

  • nzTarget has been removed, use nzContainer instead.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #5776 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5776      +/-   ##
==========================================
- Coverage   90.07%   90.06%   -0.01%     
==========================================
  Files         455      455              
  Lines       13859    13856       -3     
  Branches     2189     2187       -2     
==========================================
- Hits        12483    12479       -4     
- Misses        850      851       +1     
  Partials      526      526              
Impacted Files Coverage Δ
components/anchor/anchor.component.ts 97.08% <100.00%> (+0.86%) ⬆️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5baae...e6edb89. Read the comment docs.

BREAKING CHANGES:

- `nzTarget` has been removed, use `nzContainer` instead.
@hsuanxyz hsuanxyz force-pushed the chore/deprecated-anchor branch from b56ff72 to e6edb89 Compare September 15, 2020 06:38
@hsuanxyz hsuanxyz merged commit e50d530 into NG-ZORRO:master Sep 15, 2020
@hsuanxyz hsuanxyz deleted the chore/deprecated-anchor branch September 15, 2020 07:26
@github-actions
Copy link

github-actions bot commented Sep 15, 2020

😭 Deploy PR Preview e50d530 failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant